Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QAA-309][Detox][Speculos] Verify address test #8648

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

abdurrahman-ledger
Copy link
Contributor

@abdurrahman-ledger abdurrahman-ledger commented Dec 9, 2024

βœ… Checklist

  • npx changeset was attached. (no need)
  • Covered by automatic tests.
  • Impact of the changes:
    • LLM Tests

πŸ“ Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 3:33pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 3:33pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 3:33pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 3:33pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ui Has changes in the design system library labels Dec 9, 2024
Base automatically changed from support/qaa_342_detox_speculos_delete_account to develop December 10, 2024 08:56
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_309_detox_speculos_verify_address branch from be061dc to 64c2e5f Compare December 10, 2024 12:02
@abdurrahman-ledger abdurrahman-ledger marked this pull request as ready for review December 10, 2024 13:53
@abdurrahman-ledger abdurrahman-ledger requested review from a team as code owners December 10, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants